CWE-103 Structs：不完整的validate()方法定义

Struts: Incomplete validate() Method Definition

结构: Simple

Abstraction: Variant

状态: Draft

被利用可能性: unkown

基本描述

The application has a validator form that either does not define a validate() method, or defines a validate() method but does not call super.validate().

扩展描述

If you do not call super.validate(), the Validation Framework cannot check the contents of the form against a validation form. In other words, the validation framework will be disabled for the given form.

适用平台

Language: {'cwe_Name': 'Java', 'cwe_Prevalence': 'Undetermined'}

常见的影响

范围	影响	注释
Other	Other	Disabling the validation framework for a form exposes the application to numerous types of attacks. Unchecked input is the root cause of vulnerabilities like cross-site scripting, process control, and SQL injection.
['Confidentiality', 'Integrity', 'Availability', 'Other']	Other	Although J2EE applications are not generally susceptible to memory corruption attacks, if a J2EE application interfaces with native code that does not perform array bounds checking, an attacker may be able to use an input validation mistake in the J2EE application to launch a buffer overflow attack.

可能的缓解方案

Implementation

策略:

Implement the validate() method and call super.validate() within that method.

示例代码

例

In the following Java example the class RegistrationForm is a Struts framework ActionForm Bean that will maintain user input data from a registration webpage for an online business site. The user will enter registration data and the RegistrationForm bean in the Struts framework will maintain the user data. Tthe RegistrationForm class implements the validate method to validate the user input entered into the form.

bad Java

public class RegistrationForm extends org.apache.struts.validator.ValidatorForm {

// private variables for registration form
private String name;
private String email;
...

public RegistrationForm() {

super();

}

public ActionErrors validate(ActionMapping mapping, HttpServletRequest request) {

ActionErrors errors = new ActionErrors();
if (getName() == null || getName().length() < 1) {

errors.add("name", new ActionMessage("error.name.required"));

}
return errors;

}

// getter and setter methods for private variables
...

}

Although the validate method is implemented in this example the method does not call the validate method of the ValidatorForm parent class with a call super.validate(). Without the call to the parent validator class only the custom validation will be performed and the default validation will not be performed. The following example shows that the validate method of the ValidatorForm class is called within the implementation of the validate method.

good Java

public class RegistrationForm extends org.apache.struts.validator.ValidatorForm {

// private variables for registration form
private String name;
private String email;
...

public RegistrationForm() {

super();

}

public ActionErrors validate(ActionMapping mapping, HttpServletRequest request) {

ActionErrors errors = super.validate(mapping, request);
if (errors == null) {

errors = new ActionErrors();

}

if (getName() == null || getName().length() < 1) {